-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Properly extract copyright information from bundled packages #45833
Conversation
Hi @carmenbianca - just wanted to get some feedback (given you have some time for it of course). 😃 During the quest of making the Nextcloud server REUSE compliant we faces Javascript compiled assets - which are combined from various sources - welcome to modern web development... - so they come with various licenses in some scenarios, like as one example. Given the licenses are compatible would the |
@AndyScherzinger If I understand correctly, the source code from multiple files is mashed into a single file?
Alternatively, instead of doing |
@carmenbianca yes, that is correct. So @susnux than we can keep the current logic for the moment. Of course it would still be interesting to know if a list of license ID lines would implicitly be |
fa5a63f
to
0d0908a
Compare
0d0908a
to
33e5945
Compare
c98a8e4
to
9f18646
Compare
9f18646
to
f2b9b7a
Compare
f2b9b7a
to
bcb7977
Compare
bcb7977
to
61d3e5a
Compare
…ed assets This will create proper extracted license information for assets and stores it in `fist/file.js.license`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
61d3e5a
to
876beec
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Woohoo, all green @susnux 🎉 Now I will have to find the wrong license identifier sources and how to get the license comment into some dist JS file where there is none. Again thanks a lot for your contributions in getting this topic done for the server repo! Makes my days 💯🎉🙏😊👍💪 |
Summary
Currently we only extract comments, this does not work as most dependencies are either minified or do not contain license headers.
So this instead adds a webpack plugin to iterate all bundled sources, extract the license information and create a proper
.license
file.I really hope to drop this when migrating to vite 😅
Checklist